PIA-1882: Refresh Auth tokens if needed on every request #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kp-juan-docal
approved these changes
May 31, 2024
| if let error { | ||
| completion(error) | ||
| } else { | ||
| completion(nil) |
There was a problem hiding this comment.
nit: wouldn't this one line completion(error) achieve the same given that its parameter is either an error object or null? And if that's the case, we might not need the method altogether 🤔
There was a problem hiding this comment.
yes, absolutely , you're right 👍
Let me update it, thanks!
kp-laura-sempere
deleted the
PIA-1882_execute_tokens_check_on_all_api_calls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Network client will make a call to check whether the auth tokens should be refreshed before performing a request if the configuration has the property
refreshAuthTokensIfNeededenabled -> this gives us the flexibility to execute requests with and without refreshing tokensThe
RefreshAuthTokensCheckerwill check the expiration date of both the api and vpn tokens. And it will refresh them only if they are going to expire in less than 30 days. Note: we can adjust this number of days as we think is reasonable.