PIA-1842: Add sign up native endpoints #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kp-said-rehouni
force-pushed
the
PIA-1842_migrate_signup_endpoints
branch
from
bd75cf6 to
80598b1
Compare
kp-laura-sempere
approved these changes
Jun 6, 2024
| let inlcudeAuthHeaders: Bool = false | ||
|
|
||
| // Refreshing the auth tokens is not needed before executing the refresh API token request | ||
| let refreshAuthTokensIfNeeded: Bool = false |
There was a problem hiding this comment.
This property is no longer part of NetworkRequestConfigurationType, we just refresh the tokens directly from the use cases that need it.
There was a problem hiding this comment.
Thank you! Will update it on the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the Sign up endpoint using the new NWHttpConnection engine.
It also includes tests.