PIA-1845: Add Dedicated IP native endpoint #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kp-said-rehouni
force-pushed
the
PIA-1845_integrate_dedicatedip_endpoints
branch
3 times, most recently
from
8d210f3 to
e54ef61
Compare
| } | ||
|
|
||
| extension SignupInformationDataCoverter: JSONToStringCoverterType {} |
| } | ||
|
|
||
| private func makeConfiguration(dipTokens: [String]) -> RenewDedicatedIPRequestConfiguration { | ||
| var configuration = RenewDedicatedIPRequestConfiguration() |
There was a problem hiding this comment.
Just a question: if this is the GetDedicatedIPsUseCase, why do we execute the request with the RenewDedicatedIPRequestConfiguration?
There was a problem hiding this comment.
Good catch! Will update it. Thank you!
| @@ -32,7 +32,7 @@ extension Client { | |||
| public var accountProvider: AccountProvider = AccountFactory.makeDefaultAccountProvider() | |||
|
|
|||
| /// Provides methods for handling the available VPN servers. | |||
| public var serverProvider: ServerProvider = DefaultServerProvider() | |||
| public var serverProvider: ServerProvider = ServerProviderFactory.makeDefaultServerProvider() | |||
kp-said-rehouni
force-pushed
the
PIA-1845_integrate_dedicatedip_endpoints
branch
8 times, most recently
from
5c65b83 to
b0ff627
Compare
kp-said-rehouni
force-pushed
the
PIA-1845_integrate_dedicatedip_endpoints
branch
from
b0ff627 to
574f6b4
Compare
kp-laura-sempere
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the renew dedicated IP and get dedicated ip servers to Swift native.
It also adds unit tests for the use cases.