Add validation to check if object exists before deleting it from index (

#281) * Add validation to check if object exists before deleting it from index This fixes issue #277 It checks if the item exists first in the index before trying to delete it * Remove unnecessary return in catch validation
pimcore · Mar 7, 2025 · 06e30f7 · 06e30f7
1 parent b0edd57
commit 06e30f7
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/Service.php b/src/Service.php
@@ -497,8 +497,16 @@ public function doDeleteFromIndex(Concrete $object): void
             'id' => $object->getId()
         ];
 
-        $this->logger->info('Deleting data object ' . $object->getId() . ' from es index.');
-        $this->getClient()->delete($params);
+        try {
+            $exists = $this->getClient()->get($params);
+        } catch (Exception $e){
+            $exists = false;
+            $this->logger->debug($e->getMessage());
+        }
+        if($exists) {
+            $this->logger->info('Deleting data object ' . $object->getId() . ' from es index.');
+            $this->getClient()->delete($params);
+        }
     }
 
     /**