-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: BinarySearchRemoveVal should use decoded val instead of encoded #59131
statistics: BinarySearchRemoveVal should use decoded val instead of encoded #59131
Conversation
Encoded: b, | ||
Count: 2, | ||
} | ||
data1.RemoveVals([]TopNMeta{tmp}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RemoveVals
is actually the wrong one.
But, now that it is only used in stats v1.
I decide not to change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decide to remove it?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59131 +/- ##
================================================
+ Coverage 73.0925% 73.8625% +0.7700%
================================================
Files 1684 1714 +30
Lines 466350 476320 +9970
================================================
+ Hits 340867 351822 +10955
+ Misses 104548 102858 -1690
- Partials 20935 21640 +705
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
1 similar comment
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #59130
Problem Summary:
What changed and how does it work?
The function used the wrong val as its parameter.
As a result, when the column is not string type. The function
BinaryRemoveVal
actually removes nothing.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.