Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish AV1 Implementation #295

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Finish AV1 Implementation #295

merged 1 commit into from
Mar 1, 2025

Conversation

JoeTurki
Copy link
Member

@JoeTurki JoeTurki commented Feb 26, 2025

Description

  1. Rewrite the AV1 Payloader according to the spec.
  2. AV1 bitstream reader.
  3. Tries to optimize the use of the W field as much as possible to reduce the size of the packet.
  4. Added tests around edge cases.
  5. Deprecate AV1Packet as it has no use, and too late to change.

Tested and works as intended. I'll update the examples in the WebRTC repo accordingly.

Reference issue

pion/webrtc#3036
pion/webrtc#2788
#273
pion/webrtc#2639

@JoeTurki JoeTurki requested a review from Sean-Der February 26, 2025 22:03
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.69%. Comparing base (061df8a) to head (ee5524b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   85.99%   86.69%   +0.69%     
==========================================
  Files          26       26              
  Lines        2913     3043     +130     
==========================================
+ Hits         2505     2638     +133     
+ Misses        350      348       -2     
+ Partials       58       57       -1     
Flag Coverage Δ
go 86.69% <100.00%> (+0.69%) ⬆️
wasm 86.13% <100.00%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoeTurki JoeTurki linked an issue Feb 27, 2025 that may be closed by this pull request
@JoeTurki JoeTurki force-pushed the feat/finish-av1 branch 2 times, most recently from 65028cb to 4534adf Compare February 27, 2025 12:07
@JoeTurki
Copy link
Member Author

@Sean-Der I can confirm that this is working with chrome and gstreamer

@JoeTurki JoeTurki force-pushed the feat/finish-av1 branch 2 times, most recently from 59a09ef to 0c5defe Compare February 28, 2025 18:40
@JoeTurki
Copy link
Member Author

Thanks, I'll test it a bit more with bigger files and real video data and merge it tonight :)

@Sean-Der
Copy link
Member

@JoeTurki you are a better tester/more detail oriented then me :)

Thanks for doing this. This is going to help a lot of people building cool stuff. I am very excited for you to get the credit/attention for it!

@JoeTurki JoeTurki force-pushed the feat/finish-av1 branch 2 times, most recently from 2146e1f to 342e9d9 Compare March 1, 2025 13:45
1. Rewrite the AV1 Payloader according to the spec.
2. AV1 bitstream reader.
3. Tries to optimize the use of the W field as much as possible to
    reduce the size of the packet.
4. Added tests around edge cases.
@JoeTurki JoeTurki merged commit ee5524b into master Mar 1, 2025
15 checks passed
@JoeTurki JoeTurki deleted the feat/finish-av1 branch March 1, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AV1Payloader does not work for WebRTC
2 participants