This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Workspaces #32
Draft
b0g3r
wants to merge
9
commits into
develop
Choose a base branch
from
feature/workspaces
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Workspaces #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add vk gate - Add function to obtain token - Add function to submit post to group (to be updated) - Group all Vk API requests into a small client - Add Vk API request exception
* Add OAuth2 authentication * Fix trailing commas 🙈 * Add instruction for oauth using and basic setting * Add user registration * Fix flake8-per-file-ignores with flake8 3.7.x issues :( more info: wemake-services/wemake-python-styleguide#472 (comment) * Fix code for passing flake8 linter checks
Also remove most of superuser endpoints, because I'm not sure about them. Maybe they should be in isolated prefix, like `/admin/workspace`
teners
reviewed
Mar 9, 2019
|
||
Because most of requests to our API tied to specific workspace (e.g. | ||
work with publications), the middleware saves us from a lot of repeated | ||
code for extracting workspace by request data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
code for extracting workspace by request data. | |
code for extracting workspace from request data. |
teners
reviewed
Mar 9, 2019
|
||
def __init__(self, get_response): | ||
""" | ||
Standard interface of django middleware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Standard interface of django middleware. | |
A standard interface of Django middleware. |
teners
reviewed
Mar 9, 2019
|
||
def process_view(self, request, view_func, view_args, view_kwargs): | ||
""" | ||
One of the django middleware hook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
One of the django middleware hook. | |
One of the django middleware hooks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #19