Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BatchingSpliterator#trySplit #909

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

pivovarit
Copy link
Owner

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (3)

src/main/java/com/pivovarit/collectors/BatchingSpliterator.java:85

  • [nitpick] The variable name 'first' is ambiguous. It should be renamed to 'firstHalf' for better clarity.
var first = source.subList(0, source.size() / 2);

src/main/java/com/pivovarit/collectors/BatchingSpliterator.java:86

  • [nitpick] The variable name 'second' is ambiguous. It should be renamed to 'secondHalf' for better clarity.
var second = source.subList(source.size() / 2, source.size());

src/main/java/com/pivovarit/collectors/BatchingSpliterator.java:108

  • [nitpick] The parameter name 'numberOfBatches' is too long. It should be renamed to 'numBatches' for consistency and clarity.
private static <T> int actualBatchCount(List<T> list, int numberOfBatches) {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant