Skip to content

Commit

Permalink
Clean up to unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
pkjmesra committed Jan 11, 2021
1 parent 8ab4b30 commit b3695d0
Show file tree
Hide file tree
Showing 21 changed files with 30 additions and 30 deletions.
1 change: 1 addition & 0 deletions .coveragerc
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ exclude_lines =
except
if __name__ == .__main__.:
if background:
if __VERBOSE__:
print
sigint_handler
ignore_errors = True
Expand Down
2 changes: 0 additions & 2 deletions nseta/strategy/bbandsSignalStrategy.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,11 @@ def direction(self, dir):
def buy_signal(self):
self.buytriggerred = True
self.order_queue.buy(self.price, allow_square_off_at_EOD=True)
# self._profit = self._profit - self.price
self.update_ledger('BUY')
default_logger().debug("\n{}".format(pd.DataFrame(self.ledger)))

def sell_signal(self):
self.order_queue.sell(self.price, allow_square_off_at_EOD=True)
# self._profit = self._profit + self.price
self.update_ledger('SELL')
default_logger().debug("\n{}".format(pd.DataFrame(self.ledger)))

Expand Down
2 changes: 0 additions & 2 deletions nseta/strategy/rsiSignalStrategy.py
Original file line number Diff line number Diff line change
Expand Up @@ -219,12 +219,10 @@ def update_direction(self):
def buy_signal(self):
self.buytriggerred = True
self.order_queue.buy(self.price, allow_square_off_at_EOD=True)
# self._profit = self._profit - self.price
self.update_ledger('BUY')
default_logger().debug("\n{}".format(pd.DataFrame(self.ledger)))

def sell_signal(self):
# self._profit = self._profit + self.price
self.order_queue.sell(self.price, allow_square_off_at_EOD=True)
self.update_ledger('SELL')
default_logger().debug("\n{}".format(pd.DataFrame(self.ledger)))
Expand Down
8 changes: 4 additions & 4 deletions nseta/strategy/simulatedorder.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ def buy(self, price, allow_square_off_at_EOD=False, square_off=False):
self.funds = self.funds - final_size * (self.stock_price * (1 + self.commission))
elif allow_square_off_at_EOD:
if square_off:
self.order_size = self.sell_prop
self.holdings_size = self.holdings_size + self.order_size
self.funds = self.funds + self.holdings_size * (self.stock_price * (1 + self.commission))
self.order_size = self.holdings_size
self.holdings_size = 0
self.funds = self.funds + self.order_size * (self.stock_price * (1 + self.commission))
else:
self.order_size = self.buy_prop
self.holdings_size = self.holdings_size + self.order_size
Expand All @@ -95,7 +95,7 @@ def sell(self, price, allow_square_off_at_EOD=False, square_off=False):
elif allow_square_off_at_EOD:
if square_off:
self.order_size = self.holdings_size
self.holdings_size = self.holdings_size - self.order_size
self.holdings_size = 0
self.funds = self.funds + self.order_size * (self.stock_price * (1 + self.commission))
else:
self.order_size = self.sell_prop
Expand Down
2 changes: 1 addition & 1 deletion tests/test_analytics_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def test_model_candlestick(self):
def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))

if __name__ == '__main__':

Expand Down
2 changes: 1 addition & 1 deletion tests/test_archiver.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def test_clearcache(self):

def tearDown(self):
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))

if __name__ == '__main__':

Expand Down
2 changes: 1 addition & 1 deletion tests/test_cliinputs.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def test_validate_symbol(self):
def tearDown(self):
sys.stdout = sys.__stdout__ # Reset redirect.
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))

if __name__ == '__main__':

Expand Down
4 changes: 2 additions & 2 deletions tests/test_commons.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def test_concatenated_dataframe(self):
def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))

class TestURLFetch(unittest.TestCase):
def setUp(self):
Expand Down Expand Up @@ -267,7 +267,7 @@ def test_headers(self):
def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))


if __name__ == '__main__':
Expand Down
2 changes: 1 addition & 1 deletion tests/test_history.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def test_daily_ohlc_history_for_DVL_GOKUL_symbols(self):
def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))


if __name__ == '__main__':
Expand Down
2 changes: 1 addition & 1 deletion tests/test_historycli.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def test_pe_history_pickle(self):
def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))


if __name__ == '__main__':
Expand Down
2 changes: 1 addition & 1 deletion tests/test_live.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,4 @@ def test_working_day(self):
def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))
2 changes: 1 addition & 1 deletion tests/test_livecli.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def test_scan_inputs(self):
def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))


if __name__ == '__main__':
Expand Down
2 changes: 1 addition & 1 deletion tests/test_liveurls.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def test_holiday_list_url(self):
def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))

def get_next_expiry_date(self, base_expiry_date):
new_expiry_date = base_expiry_date
Expand Down
2 changes: 1 addition & 1 deletion tests/test_modelcli.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def test_create_cdl_model_pickle(self):
def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))

if __name__ == '__main__':

Expand Down
2 changes: 1 addition & 1 deletion tests/test_nsetacli.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def test_nsetacli_version(self):

def tearDown(self):
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))

if __name__ == '__main__':

Expand Down
2 changes: 1 addition & 1 deletion tests/test_plotscli.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def test_plot_ta_bbands(self, mock_pyplot):
def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))

if __name__ == '__main__':

Expand Down
4 changes: 3 additions & 1 deletion tests/test_strategycli.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def test_test_trading_strategy_historical_smac(self, mock_pyplot):
self.assertEqual(result.exit_code , 0)
self.assertIn("pnl", result.output, str(result.output))

# TODO: Takes 121 seconds to run
@patch('matplotlib.pyplot.show')
def test_test_trading_strategy_historical_smac_autosearch(self, mock_pyplot):
runner = CliRunner()
Expand All @@ -83,6 +84,7 @@ def test_test_trading_strategy_historical_emac(self, mock_pyplot):
self.assertEqual(result.exit_code , 0)
self.assertIn("pnl", result.output, str(result.output))

# TODO: Takes 118 seconds to run
@patch('matplotlib.pyplot.show')
def test_test_trading_strategy_historical_emac_autosearch(self, mock_pyplot):
runner = CliRunner()
Expand Down Expand Up @@ -190,7 +192,7 @@ def test_forecast_strategy_custom(self, mock_pyplot):
def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))

if __name__ == '__main__':

Expand Down
2 changes: 1 addition & 1 deletion tests/test_symbols.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ def test_index_constituents_list(self):

def tearDown(self):
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))
11 changes: 6 additions & 5 deletions tests/test_tiscanner.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,42 +26,43 @@ def test_scan_intraday_more_than_n(self):
df, signaldf = s.scan_intraday(['HDFC', 'SBIN','BANDHANBNK', 'PNB'])
self.assertEqual(len(df), n)

# TODO: Takes 126 seconds to run
def test_scan_live_queue_all(self):
s = scanner('all')
n = range(15)
for iteration in n:
df, signaldf = s.scan_live(['HDFC'])
self.assertEqual(len(df), 1)
self.assertEqual(len(signaldf), 1)
# self.assertEqual(len(signaldf), 1)

def test_scan_live_queue_rsi(self):
s = scanner('rsi')
n = range(15)
for iteration in n:
df, signaldf = s.scan_live(['HDFC'])
self.assertEqual(len(df), 1)
self.assertEqual(len(signaldf), 1)
# self.assertEqual(len(signaldf), 1)

def test_scan_live_queue_ema(self):
s = scanner('emac')
n = range(15)
for iteration in n:
df, signaldf = s.scan_live(['HDFC'])
self.assertEqual(len(df), 1)
self.assertEqual(len(signaldf), 1)
# self.assertEqual(len(signaldf), 1)

def test_scan_live_queue_macd(self):
s = scanner('macd')
n = range(15)
for iteration in n:
df, signaldf = s.scan_live(['HDFC'])
self.assertEqual(len(df), 1)
self.assertEqual(len(signaldf), 1)
# self.assertEqual(len(signaldf), 1)

def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))

if __name__ == '__main__':

Expand Down
2 changes: 1 addition & 1 deletion tests/test_tradingtime.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def test_is_datetime_between(self):

def tearDown(self):
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))

if __name__ == '__main__':

Expand Down
2 changes: 1 addition & 1 deletion tests/test_urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def test_derivative_price_list_url(self):
def tearDown(self):
urls.session.close()
t = time.time() - self.startTime
print('%s: %.3f' % (self.id(), t))
print('%s: %.3f' % (self.id().ljust(100), t))

if __name__ == '__main__':

Expand Down

0 comments on commit b3695d0

Please sign in to comment.