Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated Submission functions are still used #10653

Closed
bozana opened this issue Dec 4, 2024 · 6 comments
Closed

Removed deprecated Submission functions are still used #10653

bozana opened this issue Dec 4, 2024 · 6 comments
Assignees
Labels
Bug:1:Minor A bug found in uncommon paths, with low consequences, limited users or has an easy workaround
Milestone

Comments

@bozana
Copy link
Collaborator

bozana commented Dec 4, 2024

There are still some earlier deprecated functions that were removed here #9693, e.g. Submission::getDiscipline() in oai_marc. These lead to an error and needs to be fixed till 3.5.

@bozana bozana added this to the 3.5 Internal milestone Dec 4, 2024
@bozana bozana added the Bug:1:Minor A bug found in uncommon paths, with low consequences, limited users or has an easy workaround label Dec 4, 2024
@kaitlinnewson kaitlinnewson self-assigned this Dec 5, 2024
kaitlinnewson added a commit to kaitlinnewson/ojs that referenced this issue Dec 6, 2024
@kaitlinnewson
Copy link
Member

PR for functions found in OJS: pkp/ojs#4543

Additional plugins to review for calls to deprecated functions are documented in #9912.

kaitlinnewson added a commit to kaitlinnewson/ojs that referenced this issue Dec 6, 2024
kaitlinnewson added a commit to kaitlinnewson/ojs that referenced this issue Dec 10, 2024
kaitlinnewson added a commit to kaitlinnewson/ojs that referenced this issue Dec 11, 2024
bozana added a commit to pkp/ojs that referenced this issue Dec 12, 2024
pkp/pkp-lib#10653 remove deprecated submission functions in OAI class…
@kaitlinnewson
Copy link
Member

@bozana could this be closed now, or should we wait until plugins have all been updated as well?

@bozana
Copy link
Collaborator Author

bozana commented Dec 16, 2024

Hmmm... I currently have all plugins locally present, so I am going to check them regarding this issue... Found a few that needs to be adapted... So lets leave it open for now...

@bozana
Copy link
Collaborator Author

bozana commented Dec 16, 2024

Hi @kaitlinnewson, could you please review the PRs? Thanks a lot!

@kaitlinnewson
Copy link
Member

Hi @bozana, all reviewed! Just a couple of comments left on the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Minor A bug found in uncommon paths, with low consequences, limited users or has an easy workaround
Projects
Development

No branches or pull requests

5 participants