Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecated submission functions #38

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix deprecated submission functions #38

merged 2 commits into from
Dec 19, 2024

Conversation

bozana
Copy link

@bozana bozana commented Dec 16, 2024

@bozana bozana mentioned this pull request Dec 16, 2024
Closed
@kaitlinnewson
Copy link
Member

I see we are not using the Repository for Submissions in SwordHandler.php, should this be updated as well?

sword/SwordHandler.php

Line 114 in 2782ae5

$submissionDao = DAORegistry::getDAO('SubmissionDAO');

@asmecher
Copy link
Member

I see we are not using the Repository for Submissions...

Yes, that looks like it was forgotten, thanks!

@bozana bozana merged commit 0040487 into pkp:main Dec 19, 2024
@bozana bozana deleted the 10653 branch December 19, 2024 10:04
@bozana
Copy link
Author

bozana commented Dec 19, 2024

Thanks @kaitlinnewson! I considered that (and a few other things) and merged, but also this plugin will require deeper look for 3.5....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaitlinnewson kaitlinnewson kaitlinnewson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bozana @kaitlinnewson @asmecher