pkp/pkp-lib#10076 show declined/cancelled reviews to editors #10847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitaliy-1
requested changes
Jan 29, 2025
| // is the user a manager, sub-editor, or site admin? | ||
| $canSeeAllReviewAssignments = ( | ||
| in_array(Role::ROLE_ID_MANAGER, $currentUserRoleIds) || | ||
| in_array(Role::ROLE_ID_SUB_EDITOR, $currentUserRoleIds) || |
There was a problem hiding this comment.
We shouldn't include here submission editors not assigned to the submission. And probably managers and admins assigned into the submission in the author role or reviewer role. Or assigned to the other stage than the review.
We already calculated roles in the stages property:
pkp-lib/schemas/submission.json
Line 253 in aac75ee
Using it you can actually check if the user has those roles, it includes global ones and those related to the assignment.
And also you can use array_intersect() instead of in_array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #10076