Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock API testing, postprocess refactor #100

Merged
merged 4 commits into from
Aug 4, 2024
Merged

Mock API testing, postprocess refactor #100

merged 4 commits into from
Aug 4, 2024

Conversation

brownsugar-bobamilktea
Copy link
Contributor

  • Moved postprocess module into fetch entry folder since it makes more sense there
  • Changed tests so API is only called once per language to test the schema
  • Testing _fetch_entry_with_json instead uses mocked results to save time
  • Added more error checking in _fetch_entry_with_json

Note: there is one xfailed test (it fails but the bug/functionality can't be immediately fixed) that needs to be dealt with some time in the future

Co-authored-by: Howard Tseng <howardt12345@gmail.com>
@howardt12345 howardt12345 merged commit e5db37a into main Aug 4, 2024
1 check passed
@howardt12345 howardt12345 deleted the mock-apis branch August 4, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants