Fix subscriptions slow to update #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that we only sent out info about new subs to relays every 10 seconds. So in the worst scenario of creating subscriptions sequentially like with purple pages we had to wait 10 seconds per subscription. I am very tired but I think there is an invariant in this code that new channel is only created when there is no need for an update therefore we won't end up in the situation where channel is closed but no update happens? We can therefore drop time.After completely.
|
This could be a fix for #48. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that we only sent out info about new subs to relays every 10 seconds. So in the worst scenario of creating subscriptions sequentially like with purple pages we had to wait 10 seconds per subscription.
I am very tired but I think there is an invariant in this code that new channel is only created when there is no need for an update therefore we won't end up in the situation where channel is closed but no update happens? We can therefore drop time.After completely.