Redirection handling changes #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stopgap to improve redirect handling Addresses two bugs: - request configuration is not carried forward, - after redirect handling, replyFinished triggers errors accessing members on self.reply (set to None) The redirections parameter is now meaningful. Refactoring to avoid re-passing arguments on redirect probably appropriate longer term.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks, I noticed that redirections weren't being handled properly when I was using this library - they would result in an error, due to an attempt to access
self.replywhen it was set toNone, and I noticed that other request arguments would revert to defaults on the redirect call as well.Have added some simple fixes which have been sufficient for my needs. You may or may not want to use as-is but I thought my fixes would be useful as an illustration of the issues either way.