Merge pull request #248 from psantos10/fix-decode-types-varint

Fix RowBinary decoding issue when their sizes exceeds 127 bytes
plausible · Feb 25, 2025 · 63f23cc · 63f23cc
2 parents a653833 + 7707923
commit 63f23cc
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/lib/ch/row_binary.ex b/lib/ch/row_binary.ex
@@ -631,8 +631,14 @@ defmodule Ch.RowBinary do
     decode_rows(types, rest, _row = [], _rows = [], types)
   end
 
-  defp decode_types(<<size, type::size(size)-bytes, rest::bytes>>, count, acc) do
-    decode_types(rest, count - 1, [type | acc])
+  for {pattern, value} <- varints do
+    defp decode_types(
+           <<unquote(pattern), type::size(unquote(value))-bytes, rest::bytes>>,
+           count,
+           acc
+         ) do
+      decode_types(rest, count - 1, [type | acc])
+    end
   end
 
   @doc false