Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trailing slash causing watcher to crash #27

Merged
merged 2 commits into from
May 13, 2024
Merged

fix: trailing slash causing watcher to crash #27

merged 2 commits into from
May 13, 2024

Conversation

Zyie
Copy link
Collaborator

@Zyie Zyie commented May 10, 2024

No description provided.

@Zyie Zyie requested a review from GoodBoyDigital May 10, 2024 11:05
GoodBoyDigital
GoodBoyDigital approved these changes May 13, 2024
View reviewed changes
Copy link

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a test to cover the normalizePath function pls?

@Zyie Zyie merged commit 7c4ef87 into main May 13, 2024
4 checks passed
@Zyie Zyie deleted the fix/trailing-path branch May 13, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoodBoyDigital GoodBoyDigital GoodBoyDigital approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zyie @GoodBoyDigital