Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency eslint to v9 #260

Closed
wants to merge 1 commit into from
Closed

Update dependency eslint to v9 #260

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Jul 1, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) 8.54.0 -> 9.9.1 age adoption passing confidence

Release Notes

eslint/eslint (eslint)

v9.9.1

Compare Source

v9.9.0

Compare Source

Features

  • 41d0206 feat: Add support for TS config files (#​18134) (Arya Emami)
  • 3a4eaf9 feat: add suggestion to require-await to remove async keyword (#​18716) (Dave)

Documentation

  • 9fe068c docs: how to author plugins with configs that extend other configs (#​18753) (Alec Gibson)
  • 48117b2 docs: add version support page in the side navbar (#​18738) (Amaresh S M)
  • fec2951 docs: add version support page to the dropdown (#​18730) (Amaresh S M)
  • 38a0661 docs: Fix typo (#​18735) (Zaina Al Habash)
  • 3c32a9e docs: Update yarn command for creating ESLint config (#​18739) (Temitope Ogunleye)
  • f9ac978 docs: Update README (GitHub Actions Bot)

Chores

v9.8.0

Compare Source

v9.7.0

Compare Source

Features

  • 7bd9839 feat: add support for es2025 duplicate named capturing groups (#​18630) (Yosuke Ota)
  • 1381394 feat: add regex option in no-restricted-imports (#​18622) (Nitin Kumar)

Bug Fixes

  • 14e9f81 fix: destructuring in catch clause in no-unused-vars (#​18636) (Francesco Trotta)

Documentation

  • 9f416db docs: Add Powered by Algolia label to the search. (#​18633) (Amaresh S M)
  • c8d26cb docs: Open JS Foundation -> OpenJS Foundation (#​18649) (Milos Djermanovic)
  • 6e79ac7 docs: loadESLint does not support option cwd (#​18641) (Francesco Trotta)

Chores

v9.6.0

Compare Source

v9.5.0

Compare Source

v9.4.0

Compare Source

v9.3.0

Compare Source

v9.2.0

Compare Source

v9.1.1

Compare Source

v9.1.0

Compare Source

v9.0.0

Compare Source

v8.57.0

Compare Source

Features

  • 1120b9b feat: Add loadESLint() API method for v8 (#​18098) (Nicholas C. Zakas)
  • dca7d0f feat: Enable eslint.config.mjs and eslint.config.cjs (#​18066) (Nitin Kumar)

Bug Fixes

  • 2196d97 fix: handle absolute file paths in FlatRuleTester (#​18064) (Nitin Kumar)
  • 69dd1d1 fix: Ensure config keys are printed for config errors (#​18067) (Nitin Kumar)
  • 9852a31 fix: deep merge behavior in flat config (#​18065) (Nitin Kumar)
  • 4c7e9b0 fix: allow circular references in config (#​18056) (Milos Djermanovic)

Documentation

Chores

v8.56.0

Compare Source

Features
  • 0dd9704 feat: Support custom severity when reporting unused disable directives (#​17212) (Bryan Mishkin)
  • 31a7e3f feat: fix no-restricted-properties false negatives with unknown objects (#​17818) (Arka Pratim Chaudhuri)
Bug Fixes
  • 7d5e5f6 fix: TypeError: fs.exists is not a function on read-only file system (#​17846) (Francesco Trotta)
  • 74739c8 fix: suggestion with invalid syntax in no-promise-executor-return rule (#​17812) (Bryan Mishkin)
Documentation
  • 9007719 docs: update link in ways-to-extend.md (#​17839) (Amel SELMANE)
  • 3a22236 docs: Update README (GitHub Actions Bot)
  • 54c3ca6 docs: fix migration-guide example (#​17829) (Tanuj Kanti)
  • 4391b71 docs: check config comments in rule examples (#​17815) (Francesco Trotta)
  • fd28363 docs: remove mention about ESLint stylistic rules in readme (#​17810) (Zwyx)
  • 48ed5a6 docs: Update README (GitHub Actions Bot)
Chores

v8.55.0

Compare Source

Features

  • 8c9e6c1 feat: importNamePattern option in no-restricted-imports (#​17721) (Tanuj Kanti)

Documentation

  • 83ece2a docs: fix typo --rules -> --rule (#​17806) (OKURA Masafumi)
  • fffca5c docs: remove "Open in Playground" buttons for removed rules (#​17791) (Francesco Trotta)
  • a6d9442 docs: fix correct/incorrect examples of rules (#​17789) (Tanuj Kanti)
  • 383e999 docs: update and fix examples for no-unused-vars (#​17788) (Tanuj Kanti)
  • 5a8efd5 docs: add specific stylistic rule for each deprecated rule (#​17778) (Etienne)

Chores

Configuration

📅 Schedule: Branch creation - "on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from PatrikMatiasko July 1, 2024 09:14
@renovate Renovate
Copy link
Author

renovate bot commented Jul 1, 2024 •
edited
Loading

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: web/package-lock.json
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @babel/eslint-parser@7.23.3
npm warn Found: eslint@9.9.1
npm warn node_modules/eslint
npm warn   dev eslint@"9.9.1" from the root project
npm warn   6 more (@eslint-community/eslint-utils, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer eslint@"^7.5.0 || ^8.0.0" from @babel/eslint-parser@7.23.3
npm warn node_modules/@babel/eslint-parser
npm warn   @babel/eslint-parser@"^7.16.3" from eslint-config-react-app@7.0.1
npm warn   node_modules/eslint-config-react-app
npm warn
npm warn Conflicting peer dependency: eslint@8.57.0
npm warn node_modules/eslint
npm warn   peer eslint@"^7.5.0 || ^8.0.0" from @babel/eslint-parser@7.23.3
npm warn   node_modules/@babel/eslint-parser
npm warn     @babel/eslint-parser@"^7.16.3" from eslint-config-react-app@7.0.1
npm warn     node_modules/eslint-config-react-app
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: @emotion/eslint-plugin@11.11.0
npm warn Found: eslint@9.9.1
npm warn node_modules/eslint
npm warn   dev eslint@"9.9.1" from the root project
npm warn   6 more (@eslint-community/eslint-utils, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer eslint@"6 || 7 || 8" from @emotion/eslint-plugin@11.11.0
npm warn node_modules/@emotion/eslint-plugin
npm warn   @emotion/eslint-plugin@"^11.11.0" from @plgd/shared-ui@1.1.0
npm warn   packages/shared-ui
npm warn
npm warn Conflicting peer dependency: eslint@8.57.0
npm warn node_modules/eslint
npm warn   peer eslint@"6 || 7 || 8" from @emotion/eslint-plugin@11.11.0
npm warn   node_modules/@emotion/eslint-plugin
npm warn     @emotion/eslint-plugin@"^11.11.0" from @plgd/shared-ui@1.1.0
npm warn     packages/shared-ui
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @typescript-eslint/eslint-plugin@6.13.1
npm error Found: eslint@9.9.1
npm error node_modules/eslint
npm error   dev eslint@"9.9.1" from the root project
npm error   peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@4.4.0
npm error   node_modules/@eslint-community/eslint-utils
npm error     @eslint-community/eslint-utils@"^4.2.0" from @typescript-eslint/utils@5.62.0
npm error     node_modules/@typescript-eslint/experimental-utils/node_modules/@typescript-eslint/utils
npm error       @typescript-eslint/utils@"5.62.0" from @typescript-eslint/experimental-utils@5.62.0
npm error       node_modules/@typescript-eslint/experimental-utils
npm error         @typescript-eslint/experimental-utils@"^5.0.0" from eslint-plugin-jest@25.7.0
npm error         node_modules/eslint-config-react-app/node_modules/eslint-plugin-jest
npm error     @eslint-community/eslint-utils@"^4.4.0" from @typescript-eslint/utils@6.13.1
npm error     node_modules/@typescript-eslint/utils
npm error       @typescript-eslint/utils@"6.13.1" from @typescript-eslint/eslint-plugin@6.13.1
npm error       node_modules/@typescript-eslint/eslint-plugin
npm error         peerOptional @typescript-eslint/eslint-plugin@"^5.0.0 || ^6.0.0" from eslint-plugin-jest@27.6.0
npm error         node_modules/eslint-plugin-jest
npm error         1 more (@plgd/shared-ui)
npm error       1 more (@typescript-eslint/type-utils)
npm error     7 more (@typescript-eslint/utils, @typescript-eslint/utils, ...)
npm error   5 more (eslint-config-prettier, ...)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^7.0.0 || ^8.0.0" from @typescript-eslint/eslint-plugin@6.13.1
npm error node_modules/@typescript-eslint/eslint-plugin
npm error   peerOptional @typescript-eslint/eslint-plugin@"^5.0.0 || ^6.0.0" from eslint-plugin-jest@27.6.0
npm error   node_modules/eslint-plugin-jest
npm error     dev eslint-plugin-jest@"^27.6.0" from the root project
npm error     1 more (@plgd/shared-ui)
npm error   @typescript-eslint/eslint-plugin@"^6.12.0" from @plgd/shared-ui@1.1.0
npm error   packages/shared-ui
npm error     @plgd/shared-ui@1.1.0
npm error     node_modules/@plgd/shared-ui
npm error
npm error Conflicting peer dependency: eslint@8.57.0
npm error node_modules/eslint
npm error   peer eslint@"^7.0.0 || ^8.0.0" from @typescript-eslint/eslint-plugin@6.13.1
npm error   node_modules/@typescript-eslint/eslint-plugin
npm error     peerOptional @typescript-eslint/eslint-plugin@"^5.0.0 || ^6.0.0" from eslint-plugin-jest@27.6.0
npm error     node_modules/eslint-plugin-jest
npm error       dev eslint-plugin-jest@"^27.6.0" from the root project
npm error       1 more (@plgd/shared-ui)
npm error     @typescript-eslint/eslint-plugin@"^6.12.0" from @plgd/shared-ui@1.1.0
npm error     packages/shared-ui
npm error       @plgd/shared-ui@1.1.0
npm error       node_modules/@plgd/shared-ui
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2024-08-23T22_35_47_597Z-eresolve-report.txt
npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-08-23T22_35_47_597Z-debug-0.log

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 1, 2024 •
edited
Loading

Walkthrough

The primary change involves updating the eslint package version in the web/package.json file from 8.54.0 to 9.9.1. This upgrade may introduce enhancements in linting capabilities, including new features, improvements, and bug fixes, thereby refining code quality checks. No other dependencies were modified, indicating a focused effort to enhance the development environment without additional complexity.

Changes

File Change Summary
web/package.json Updated eslint from 8.54.0 to 9.9.1

Poem

In the garden of code, with a hop and a leap,
The linting gets fresh, no need for a peep.
From eight point five to nine point nine,
Bugs run away, and the rules all align.
Hooray for the changes, let's dance in delight,
A cleaner code base, oh what a sight! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch from c3c10ca to 8b7db3c Compare July 12, 2024 21:11
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch from 8b7db3c to 78abe3b Compare July 26, 2024 21:27
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch from 78abe3b to bef0d29 Compare August 9, 2024 21:11
coderabbitai[bot]
coderabbitai bot reviewed Aug 9, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e72e9f8 and bef0d29.

Files selected for processing (1)
  • web/package.json (1 hunks)
Additional comments not posted (1)
web/package.json (1)

51-51: Verify compatibility with ESLint 9.9.0.

Ensure that the existing ESLint configuration and codebase are compatible with the updated version. New rules or changes in behavior might require adjustments in the configuration or code.

@renovate
Update dependency eslint to v9
f9d8345 
Generated by renovateBot
@renovate renovate bot force-pushed the renovate/major-eslint-monorepo branch from bef0d29 to f9d8345 Compare August 23, 2024 22:35
coderabbitai[bot]
coderabbitai bot reviewed Aug 23, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bef0d29 and f9d8345.

Files selected for processing (1)
  • web/package.json (1 hunks)
Additional comments not posted (1)
web/package.json (1)

51-51: Verify ESLint configuration and plugin compatibility.

The ESLint version has been updated from 8.54.0 to 9.9.1. Ensure that all ESLint configurations and plugins (eslint-config-prettier, eslint-config-react-app, eslint-plugin-import, eslint-plugin-jest, eslint-plugin-jsx-a11y, eslint-plugin-prettier, eslint-plugin-react, eslint-plugin-react-hooks) are compatible with the new version.

Run the following script to check for compatibility issues:

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@renovate Renovate
Copy link
Author

renovate bot commented Sep 4, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 9.x releases. But if you manually upgrade to 9.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/major-eslint-monorepo branch September 4, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@PatrikMatiasko PatrikMatiasko Awaiting requested review from PatrikMatiasko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Danielius1922