Skip to content

Commit

Permalink
Small doc update
Browse files Browse the repository at this point in the history
Signed-off-by: Thomas Bleher <thomas.tb.bleher@bmw.de>
  • Loading branch information
tbleher authored and Stefan Cyliax committed Mar 31, 2022
1 parent 49d7050 commit f46fb9c
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 15 deletions.
4 changes: 2 additions & 2 deletions osi_common.proto
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ message Spherical3d
//
// As an exception to this, \c TrafficSign and \c TrafficLight are assigned to
// a logical lane if they control traffic on that lane. For \c TrafficSign and
// \c TrafficLight , s_position refers to the position where the sign or light
// \c TrafficLight , #s_position refers to the position where the sign or light
// is valid (e.g. where vehicles should stop in case of a red traffic light),
// not the physical position (where the sign or light is in the world).
// Typically, t_position and angle_to_lane do not have any meaning in this
Expand All @@ -367,7 +367,7 @@ message LogicalLaneAssignment
// S position of the object reference point on the lane, in the ST
// coordinate system of the lane.
//
// s_position might be outside [s_start,s_end] of the lane (and even
// #s_position might be outside [s_start,s_end] of the lane (and even
// outside [startS,endS] of the reference line) if the reference point is
// outside the lane, but the object overlaps the lane or a TrafficSign or
// TrafficLight is assigned to a lane.
Expand Down
29 changes: 16 additions & 13 deletions osi_logicallane.proto
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ package osi3;
// - No centerline of the lane is necessary, since this can very easily be
// generated from the boundaries.
// Disadvantages of this decision:
// - Lane boundaries cannot be shared with physical lanes. This results in
// - %Lane boundaries cannot be shared with physical lanes. This results in
// more data needed. This can mostly be mitigated by only transmitting the
// lane boundaries during initialization (e.g. via the OSMP GroundTruthInit
// message).
Expand Down Expand Up @@ -359,6 +359,11 @@ message LogicalLane
// reference_line, so that vehicles that are next to each other on
// neighbouring lanes have comparable S positions.
//
// The S coordinate of the reference line makes it easy to find e.g. which
// object is next on a lane, using the LogicalLaneAssignment of the
// objects.
//
//
// \rules
// refers_to: ReferenceLine
// \endrules
Expand All @@ -372,7 +377,8 @@ message LogicalLane

// End S position of the lane. Must be in range [sStart,sEnd] of the
// reference line.
// end_s > start_s
//
// Requirement: #end_s > #start_s
//
optional double end_s = 7;

Expand All @@ -386,7 +392,7 @@ message LogicalLane
// Lanes that are directly right of this lane, without gap or overlap.
// "Right" is in definition direction (not driving direction), so right lanes
// have smaller T coordinates.
// Entries must be ordered: first by start_s, then by end_s.
// Entries must be ordered: first by #start_s, then by #end_s.
//
// The XY positions of the polyline generated by the LogicalLaneBoundaries
// of adjacent lanes must match up to a small error (5cm).
Expand All @@ -402,7 +408,7 @@ message LogicalLane
// Lanes that are directly left of this lane, without gap or overlap.
// "Left" is in definition direction (not driving direction), so left lanes
// have larger T coordinates.
// Entries must be ordered: first by start_s, then by end_s.
// Entries must be ordered: first by #start_s, then by #end_s.
//
// The XY positions of the polyline generated by the LogicalLaneBoundaries
// of adjacent lanes must match up to a small error (5cm).
Expand All @@ -418,7 +424,7 @@ message LogicalLane
// Lanes that partially or completely overlap this lane. Only overlaps
// laterally larger than 5cm are considered overlaps for the purpose of
// this relation.
// Entries must be ordered: first by start_s, then by end_s.
// Entries must be ordered: first by #start_s, then by #end_s.
//
repeated LaneRelation overlapping_lane = 11;

Expand Down Expand Up @@ -579,7 +585,7 @@ message LogicalLane

// S position on the logical lane where the physical lane ends
//
// Requirement: end_s > start_s
// Requirement: #end_s > #start_s
//
optional double end_s = 3;
}
Expand Down Expand Up @@ -623,28 +629,25 @@ message LogicalLane

// End s position of the relation
//
// Requirement: end_s > start_s
// Requirement: #end_s > #start_s
//
optional double end_s = 3;

// Start s position of the relation on the other lane.
//
// This is the same place as start_s, but measured along the reference
// This is the same place as #start_s, but measured along the reference
// line of the other lane.
//
optional double start_s_other = 4;

// End s position of the relation on the other lane.
//
// This is the same place as end_s, but measured along the reference
// This is the same place as #end_s, but measured along the reference
// line of the other lane.
//
// Note: end_s_other might be smaller than start_s_other
// Note: #end_s_other might be smaller than #start_s_other
//
optional double end_s_other = 5;
}
}

// TODO Traffic Agents also need the physical area of an intersection. This
// should be added to physical lanes of type TYPE_INTERSECTION.

0 comments on commit f46fb9c

Please sign in to comment.