Expand 90.1 Unitary Air Conditioners data #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand and update 90.1 Air Conditioning data
AmmarDeh
changed the title
Checked errata data and removed 90.1-2007 AirCooled Small Duct High Velocity entry accordingly. Added more annotations.
lymereJ
requested changes
Jan 23, 2024
There was a problem hiding this comment.
The JSON file is too large so I have to put my comments here:
- The
end_datefor theReplacementsPTAC may be incorrect. - Small detail but The terms under "application" previously called "New Construction"and "Replacement". should be The terms under "application" previously called "New Construction" and "Replacements".
- I think that for the newer code versions, the most recent requirements some of the air-cooled units are IEER only (see email that I sent)
Comment on lines
21
to
22
| minimum_seasonal_efficiency: NUMERIC | ||
| minimum_seasonal_efficiency_2: NUMERIC |
There was a problem hiding this comment.
I think we should probably correct this. SEER stands for Seasonal Energy Efficiency Ratio, not seasonal efficiency.
Removed EER requirements and kept IEER only for some of the Air Conditioners in Table 6.8.1-1 in 90.1-2013, 90.1-2019 and 90.1-2022. Changed "minimum_seasonal_efficiency" column name to "minimum_seasonal_energy_efficiency_ratio".
Added a new column "minimum_coefficient_of_performance_no_fan_cooling" to capture efficiency requirements in 90.1-2019 and 90.1-2022 PRM.
lymereJ
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand and update 90.1 Air Conditioning data