IECC heat pump Data #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lymereJ
requested changes
Mar 19, 2024
There was a problem hiding this comment.
@lzwang26 - Thanks for doing that! A couple of things:
- I think that we're missing data for the earlier code version. See note "c" below Table 503.2.3(2) in IEEC-2006 for example. We're currently using "All Other" with the requirements that are in the table but I think that these should actually be "Electric Resistance" and in turns we're missing the data for "All Other" that includes the 0.2 deduction.
- Could you please change "TABLE" in the annotation to be "Table" so it's consistent with all the other annotations.
@lymereJ , I have updated both the IECC heat pump cooling and unitary AC data related to the heating mode. I also change TABLE to table. Thank you! |
lymereJ
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IECC heat pump data to the database.