Add validation for integers and guids

pnp · Jan 20, 2025 · 582d528 · 582d528
1 parent b63164c
commit 582d528
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/src/m365/spo/commands/tenant/tenant-homesite-add.spec.ts b/src/m365/spo/commands/tenant/tenant-homesite-add.spec.ts
@@ -147,6 +147,26 @@ describe(commands.TENANT_HOMESITE_ADD, () => {
     assert.notStrictEqual(actual, true);
   });
 
+  it('correctly handles non-integer order', async () => {
+    const result = await command.validate({
+      options: {
+        url: homeSite,
+        order: 'invalid-order'
+      }
+    }, commandInfo);
+    assert.strictEqual(result, 'invalid-order is not a positive integer');
+  });
+
+  it('correctly handles invalid GUIDs in audiences', async () => {
+    const result = await command.validate({
+      options: {
+        url: homeSite,
+        audiences: 'invalid-guid'
+      }
+    }, commandInfo);
+    assert.strictEqual(result, `The following GUIDs are invalid for the option 'ids': invalid-guid.`);
+  });
+
   it('passes validation with URL', async () => {
     const actual = await command.validate({
       options: {

diff --git a/src/m365/spo/commands/tenant/tenant-homesite-add.ts b/src/m365/spo/commands/tenant/tenant-homesite-add.ts
@@ -78,6 +78,14 @@ class SpoTenantHomeSiteAddCommand extends SpoCommand {
           return isValidSharePointUrl;
         }
 
+        if (args.options.order !== undefined && !validation.isValidPositiveInteger(args.options.order)) {
+          return `${args.options.order} is not a positive integer`;
+        }
+
+        const isValidGUIDArrayResult = args.options.audiences ? validation.isValidGuidArray(args.options.audiences) : true;
+        if (isValidGUIDArrayResult !== true) {
+          return `The following GUIDs are invalid for the option 'ids': ${isValidGUIDArrayResult}.`;
+        }
         return true;
       }
     );