updates based on comments

pnp · Jan 20, 2025 · 69fb83b · 69fb83b
1 parent de55555
commit 69fb83b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/docs/docs/cmd/spo/tenant/tenant-homesite-add.mdx b/docs/docs/cmd/spo/tenant/tenant-homesite-add.mdx
@@ -25,7 +25,7 @@ m365 spo tenant homesite add [options]
 : Specifies whether the home site is the default start for Viva Connections. Accepts `true` or `false`.
 
 `--audiences [audiences]`
-: Comma-separated list of audience GUIDs.
+: Comma-separated list of audience GUIDs which are GUIDs of Microsoft Entra groups.
 
 `--order [order]`
 : Order of the home site. Must be an integer.

diff --git a/src/m365/spo/commands/tenant/tenant-homesite-add.ts b/src/m365/spo/commands/tenant/tenant-homesite-add.ts
@@ -12,6 +12,10 @@ interface CommandArgs {
 
 interface Options extends GlobalOptions {
   url: string;
+  audiences: string,
+  vivaConnectionsDefaultStart: boolean,
+  isInDraftMode: boolean,
+  order: number
 }
 
 class SpoTenantHomeSiteAddCommand extends SpoCommand {
@@ -70,16 +74,12 @@ class SpoTenantHomeSiteAddCommand extends SpoCommand {
         }
 
         if (args.options.audiences) {
-          const invalidGuid = args.options.audiences.split(',').find((guid: string | undefined) => !validation.isValidGuid(guid));
-          if (invalidGuid) {
-            return `${invalidGuid} is not a valid GUID`;
+          const validGuid = validation.isValidGuidArray(args.options.audiences);
+          if (!validGuid) {
+            return `${args.options.audiences} has an invalid GUID`;
           }
         }
 
-        if (args.options.order !== undefined && isNaN(parseInt(args.options.order))) {
-          return 'Order must be an integer';
-        }
-
         return true;
       }
     );
@@ -96,10 +96,10 @@ class SpoTenantHomeSiteAddCommand extends SpoCommand {
         responseType: 'json',
         data: {
           siteUrl: args.options.url,
-          audiences = args.options.audiences?split(','),
-          vivaConnectionsDefaultStart = args.options.vivaConnectionsDefaultStart ?? true,
-          isInDraftMode = args.options.isInDraftMode ?? true,
-          order = args.options.order
+          audiences: args.options.audiences?.split(','),
+          vivaConnectionsDefaultStart: args.options.vivaConnectionsDefaultStart ?? true,
+          isInDraftMode: args.options.isInDraftMode ?? true,
+          order: args.options.order
         }
       };