Added internalName option for spo field commands #6379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, we'll try to review it ASAP! |
MathijsVerbeeck
requested changes
Nov 29, 2024
| @@ -191,7 +196,8 @@ class SpoFieldRemoveCommand extends SpoCommand { | |||
| } | |||
| else { | |||
| try { | |||
| await removeField(listRestUrl, args.options.id, args.options.title); | |||
| const columnName: string | undefined = args.options.title ? args.options.title : args.options.internalName; | |||
There was a problem hiding this comment.
The removeField function now has a title parameter, which can contain the title or the internalName, that does not make sense. Let's just forward the entire options object into the removeField function
| @@ -158,7 +163,7 @@ class SpoFieldSetCommand extends SpoCommand { | |||
| // retrieve column CSOM object id | |||
| const fieldQuery: string = args.options.id ? | |||
| `<Method Id="663" ParentId="7" Name="GetById"><Parameters><Parameter Type="Guid">${formatting.escapeXml(args.options.id)}</Parameter></Parameters></Method>` : | |||
| `<Method Id="663" ParentId="7" Name="GetByInternalNameOrTitle"><Parameters><Parameter Type="String">${formatting.escapeXml(args.options.name || args.options.title)}</Parameter></Parameters></Method>`; | |||
| `<Method Id="663" ParentId="7" Name="GetByInternalNameOrTitle"><Parameters><Parameter Type="String">${formatting.escapeXml(args.options.name || args.options.title || args.options.internalName)}</Parameter></Parameters></Method>`; | |||
There was a problem hiding this comment.
There's an odd args.options.name here, thats not actually part of the options, lets remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6249
In this PR, i have added
internalNameoption to below commandsspo field getspo field setspo field remove