Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds command spo list defaultvalue remove #6559

Closed
wants to merge 1 commit into from
Closed

Adds command spo list defaultvalue remove #6559

wants to merge 1 commit into from

Conversation

milanholemans
Copy link
Contributor

Closes #6504

@martinlingstuyl martinlingstuyl self-assigned this Jan 15, 2025
martinlingstuyl
martinlingstuyl requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a couple of minor comments. If you could fix these I will merge it.

src/m365/spo/commands/list/list-defaultvalue-remove.ts Show resolved Hide resolved
docs/docs/cmd/spo/list/list-defaultvalue-remove.mdx Outdated Show resolved Hide resolved
src/m365/spo/commands/list/list-defaultvalue-remove.ts Show resolved Hide resolved
src/m365/spo/commands/list/list-defaultvalue-remove.ts Show resolved Hide resolved
src/m365/spo/commands/list/list-defaultvalue-remove.ts Show resolved Hide resolved
src/m365/spo/commands/list/list-defaultvalue-remove.ts Show resolved Hide resolved
src/m365/spo/commands/list/list-defaultvalue-remove.ts Show resolved Hide resolved
src/m365/spo/commands/list/list-defaultvalue-remove.ts Show resolved Hide resolved
@martinlingstuyl martinlingstuyl marked this pull request as draft January 15, 2025 12:20
@milanholemans milanholemans force-pushed the spo-list-defaultvalue-remove branch from a46dda9 to 2df4bc1 Compare January 17, 2025 22:39
@milanholemans milanholemans marked this pull request as ready for review January 17, 2025 22:39
martinlingstuyl
martinlingstuyl approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely Milan!

@martinlingstuyl
Copy link
Contributor

Merged manually, thank you 🚀

@milanholemans milanholemans deleted the spo-list-defaultvalue-remove branch January 21, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinlingstuyl martinlingstuyl martinlingstuyl approved these changes

Assignees

@martinlingstuyl martinlingstuyl

Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command: spo list defaultvalue remove
2 participants
@milanholemans @martinlingstuyl