fix: Bad null handling in unordered row encoding (#21603)

pola-rs · Mar 5, 2025 · b79df25 · b79df25
1 parent db551fb
commit b79df25
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/crates/polars-row/src/variable/no_order.rs b/crates/polars-row/src/variable/no_order.rs
@@ -126,7 +126,7 @@ pub unsafe fn decode_variable_no_order(
         validity.push(sentinel != 0xFF);
         if sentinel == 0xFF {
             array.push_value_ignore_validity("");
-            break;
+            continue;
         }
 
         let length = if sentinel < 0xFE {

diff --git a/py-polars/tests/unit/streaming/test_streaming_group_by.py b/py-polars/tests/unit/streaming/test_streaming_group_by.py
@@ -519,3 +519,15 @@ def test_streaming_group_by_boolean_mean_15610(
     )
 
     assert_frame_equal(out, expect)
+
+
+def test_streaming_group_by_all_null_21593() -> None:
+    df = pl.DataFrame(
+        {
+            "col_1": ["A", "B", "C", "D"],
+            "col_2": ["test", None, None, None],
+        }
+    )
+
+    out = df.lazy().group_by(pl.all()).min().collect(new_streaming=True)  # type: ignore[call-overload]
+    assert_frame_equal(df, out, check_row_order=False)