Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Separate "writing a plugin" from "registering an expression" in user guide, add some extra links, don't use deprecated _register_plugin #14621

Merged
merged 1 commit into from
Feb 21, 2024
Merged

docs: Separate "writing a plugin" from "registering an expression" in user guide, add some extra links, don't use deprecated _register_plugin #14621

merged 1 commit into from
Feb 21, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

@MarcoGorelli MarcoGorelli commented Feb 21, 2024 •
edited
Loading

A few things:

  • teach to use the "abi3-py38" feature by default to avoid installation issues like pip install polars-xdt fails - macOS Sonoma 14.3.1 polars-xdt#59. Advanced users who know what they're doing can always remove it
  • separate teaching to write a plugin from registering a custom accessor
  • add some extra links to the community material:
    • polars-reverse-geocode (something I used for a client, which they kindly allowed me to open source)
    • polars plugins tutorial
    • cookiecutter-polars-plugins
  • uses Expr.register_plugin instead of the deprecated Expr._register_plugin

closes #13899

@MarcoGorelli MarcoGorelli changed the title doc: update plugins material with non-deprecated methods, add some extra links doc: Separate "writing a plugin" from "registering an expression" in user guide, add some extra links, don't use deprecated _register_plugin Feb 21, 2024
@MarcoGorelli MarcoGorelli force-pushed the dont-teach-deprecated-register-plugin branch from d5d1856 to 3e9b02b Compare February 21, 2024 09:06
@MarcoGorelli MarcoGorelli force-pushed the dont-teach-deprecated-register-plugin branch from 3e9b02b to 329aa93 Compare February 21, 2024 09:30
@MarcoGorelli MarcoGorelli marked this pull request as ready for review February 21, 2024 09:31
@stinodego stinodego changed the title doc: Separate "writing a plugin" from "registering an expression" in user guide, add some extra links, don't use deprecated _register_plugin docs: Separate "writing a plugin" from "registering an expression" in user guide, add some extra links, don't use deprecated _register_plugin Feb 21, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars labels Feb 21, 2024
@ritchie46 ritchie46 merged commit b205950 into pola-rs:main Feb 21, 2024
5 checks passed
@laurentS laurentS mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate "writing a plugin" from "registering an expression" in user guide and pyo3-polars examples
2 participants
@MarcoGorelli @ritchie46