Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Make NodeTraverser struct public #18822

Merged
merged 1 commit into from
Sep 20, 2024
Merged

refactor(python): Make NodeTraverser struct public #18822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/polars-python/src/lazyframe/visit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ impl From<&ExprIR> for PyExprIR {
type Version = (u16, u16);

#[pyclass]
pub(crate) struct NodeTraverser {
pub struct NodeTraverser {
root: Node,
lp_arena: Arc<Mutex<Arena<IR>>>,
expr_arena: Arc<Mutex<Arena<AExpr>>>,
Expand All @@ -59,7 +59,7 @@ impl NodeTraverser {
// changes (e.g. exposing a new expression node).
const VERSION: Version = (2, 0);

pub(crate) fn new(root: Node, lp_arena: Arena<IR>, expr_arena: Arena<AExpr>) -> Self {
pub fn new(root: Node, lp_arena: Arena<IR>, expr_arena: Arena<AExpr>) -> Self {
Self {
root,
lp_arena: Arc::new(Mutex::new(lp_arena)),
Expand All @@ -71,7 +71,7 @@ impl NodeTraverser {
}

#[allow(clippy::type_complexity)]
pub(crate) fn get_arenas(&self) -> (Arc<Mutex<Arena<IR>>>, Arc<Mutex<Arena<AExpr>>>) {
pub fn get_arenas(&self) -> (Arc<Mutex<Arena<IR>>>, Arc<Mutex<Arena<AExpr>>>) {
(self.lp_arena.clone(), self.expr_arena.clone())
}

Expand Down