Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix use of "hidden_columns" parameter in write_excel #19029

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Sep 30, 2024

Closes #18950.
Closes #18668.

A previous update caused the "hidden_columns" parameter to become inadvertently entangled with "column_widths" (for write_excel). This PR unentangles them, fixing the related issue(s) 😅

@alexander-beedie alexander-beedie added the A-io-spreadsheet Area: reading/writing Excel/ODS files label Sep 30, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.87%. Comparing base (ab5200d) to head (b7a7f95).
Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/dataframe/frame.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19029      +/-   ##
==========================================
+ Coverage   79.85%   79.87%   +0.02%     
==========================================
  Files        1524     1524              
  Lines      207734   207750      +16     
  Branches     2908     2909       +1     
==========================================
+ Hits       165891   165946      +55     
+ Misses      41294    41254      -40     
- Partials      549      550       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit f8a7041 into pola-rs:main Oct 11, 2024
18 checks passed
@alexander-beedie alexander-beedie deleted the fix-excel-hidden-columns branch November 8, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-io-spreadsheet Area: reading/writing Excel/ODS files fix Bug fix python Related to Python Polars
Projects
None yet
2 participants