-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure parquet schema
arg is propagated to IR
#19084
Conversation
#[cfg(feature = "serde")] | ||
use serde::{Deserialize, Serialize}; | ||
|
||
#[derive(Clone, Debug, PartialEq, Eq, Hash)] | ||
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] | ||
pub struct ParquetOptions { | ||
pub schema: Option<ArrowSchemaRef>, | ||
pub schema: Option<SchemaRef>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change ParquetOptions::schema
to hold our native schema type, this reduces excess copy/conversions as that is the type we receive at input, and also the type we give to the IR. The conversion to arrow schema is now done below in to_alp_impl
and stored directly to the FileInfo::reader_schema
field
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19084 +/- ##
=======================================
Coverage 79.76% 79.76%
=======================================
Files 1531 1531
Lines 208521 208546 +25
Branches 2913 2913
=======================================
+ Hits 166332 166357 +25
Misses 41638 41638
Partials 551 551 ☔ View full report in Codecov by Sentry. |
Fixes #19081