Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Feature gate for list arithmetic #19237

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Oct 15, 2024

Make this opt-in as _finish_impl is monomorphized over every DataType x NumericOp combination

 File  .text    Size          Crate Name
 0.1%   0.4% 92.7KiB            std core::panicking::panic_const::panic_const_rem_by_zero
 0.1%   0.4% 83.5KiB   polars_arrow atoi_simd::parse_skipped
 0.1%   0.4% 78.2KiB    polars_core polars_core::fmt::<impl core::fmt::Debug for polars_core::series::Series>::fmt
 0.1%   0.2% 42.9KiB   polars_arrow atoi_simd::parse_skipped
 0.1%   0.2% 38.9KiB    polars_core polars_core::series::arithmetic::list_borrowed::inner::BinaryListNumericOpHelper::_finish_impl
 0.1%   0.2% 38.9KiB    polars_core polars_core::series::arithmetic::list_borrowed::inner::BinaryListNumericOpHelper::_finish_impl
 0.0%   0.2% 38.4KiB    polars_core polars_core::series::arithmetic::list_borrowed::inner::BinaryListNumericOpHelper::_finish_impl
 0.0%   0.2% 38.4KiB    polars_core polars_core::series::arithmetic::list_borrowed::inner::BinaryListNumericOpHelper::_finish_impl
 0.0%   0.2% 38.4KiB    polars_core polars_core::series::arithmetic::list_borrowed::inner::BinaryListNumericOpHelper::_finish_impl
 0.0%   0.2% 38.4KiB    polars_core polars_core::series::arithmetic::list_borrowed::inner::BinaryListNumericOpHelper::_finish_impl
 0.0%   0.2% 38.4KiB    polars_core polars_core::series::arithmetic::list_borrowed::inner::BinaryListNumericOpHelper::_finish_impl
 0.0%   0.2% 38.2KiB    polars_core polars_core::series::arithmetic::list_borrowed::inner::BinaryListNumericOpHelper::_finish_impl
 0.0%   0.2% 36.2KiB           rand <rand_chacha::chacha::ChaCha12Core as rand_core::block::BlockRngCore>::generate
 0.0%   0.1% 28.4KiB   polars_arrow atoi_simd::parse_skipped
 0.0%   0.1% 28.4KiB   polars_arrow atoi_simd::parse_skipped

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 96.02076% with 23 lines in your changes missing coverage. Please review.

Project coverage is 79.99%. Comparing base (d52e13e) to head (302c98f).
Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
...polars-core/src/series/arithmetic/list_borrowed.rs 96.02% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19237      +/-   ##
==========================================
- Coverage   80.00%   79.99%   -0.01%     
==========================================
  Files        1527     1527              
  Lines      209203   209211       +8     
  Branches     2415     2415              
==========================================
- Hits       167371   167368       -3     
- Misses      41284    41295      +11     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review October 15, 2024 10:35
@ritchie46 ritchie46 merged commit 9376ce3 into pola-rs:main Oct 15, 2024
21 of 22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Oct 21, 2024
@nameexhaustion nameexhaustion deleted the list-arith-feature-gate branch October 28, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants