Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Change dprint config #19747

Merged
merged 2 commits into from
Nov 16, 2024
Merged

docs: Change dprint config #19747

merged 2 commits into from
Nov 16, 2024

Conversation

rodrigogiraoserrao
Copy link
Collaborator

@rodrigogiraoserrao rodrigogiraoserrao commented Nov 12, 2024 •
edited
Loading

By changing the dprint config we get markdown files with a consistent maximum line width which makes it easier to review and diff markdown documents, especially in the docs.

@rodrigogiraoserrao rodrigogiraoserrao changed the title Change dprint config docs: Change dprint config Nov 12, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Nov 12, 2024
@rodrigogiraoserrao rodrigogiraoserrao marked this pull request as ready for review November 12, 2024 18:09
@ritchie46
Copy link
Member

Ouch.. That's a painful one. Let's get it over with. :D

Can you rebase?

@rodrigogiraoserrao
docs: Make dprint wrap long lines in markdown
9e1a4e5 
dprint is now configured to wrap text at roughly 100 characters so that lines do not get too long.
@rodrigogiraoserrao
Run dprint with new config settings.
7607f8b
@rodrigogiraoserrao
Copy link
Collaborator Author

Ouch.. That's a painful one. Let's get it over with. :D

Can you rebase?

Done 🫡

@ritchie46
Copy link
Member

The CI seems to fail (twice).

@rodrigogiraoserrao
Copy link
Collaborator Author

rodrigogiraoserrao commented Nov 14, 2024 •
edited
Loading

The CI seems to fail (twice).

Well, yes, but actually, no. The markdown-link-check fails very often on links that are working. I'm rerunning the CI job but the links it failed on are working (I double-checked).

@ritchie46 ritchie46 merged commit 9c0ff45 into pola-rs:main Nov 16, 2024
19 of 20 checks passed
@c-peters c-peters added the accepted Ready for implementation label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@coastalwhite coastalwhite Awaiting requested review from coastalwhite coastalwhite is a code owner

Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
accepted Ready for implementation documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigogiraoserrao @ritchie46 @c-peters