Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update source URL for legislators-historical.csv #20858

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

nameexhaustion
Copy link
Collaborator

The original URL at https://theunitedstates.io/congress-legislators/legislators-historical.csv currently returns a 404 and is causing CI to fail.

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars labels Jan 23, 2025
@@ -27,7 +27,10 @@ pub struct LazyCsvReader {
#[cfg(feature = "csv")]
impl LazyCsvReader {
/// Re-export to shorten code.
fn map_parse_options<F: Fn(CsvParseOptions) -> CsvParseOptions>(mut self, map_func: F) -> Self {
pub fn map_parse_options<F: Fn(CsvParseOptions) -> CsvParseOptions>(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by expose this on the Rust API

@nameexhaustion nameexhaustion marked this pull request as ready for review January 23, 2025 07:06
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (24fccc4) to head (25e867e).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20858      +/-   ##
==========================================
- Coverage   79.64%   79.64%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      223156   223159       +3     
  Branches     2546     2546              
==========================================
- Hits       177731   177726       -5     
- Misses      44841    44849       +8     
  Partials      584      584              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit ea030a5 into pola-rs:main Jan 23, 2025
25 checks passed
@c-peters c-peters added the accepted Ready for implementation label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants