fix: Warn if asof keys not sorted #20887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
|
The uncompressed lib size after this PR is 38.7883 MB. |
|
Also closes #18014? |
ritchie46
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
|
The uncompressed lib size after this PR is 38.7832 MB. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20887 +/- ##
=======================================
Coverage 79.73% 79.73%
=======================================
Files 1566 1566
Lines 222581 222633 +52
Branches 2572 2572
=======================================
+ Hits 177469 177524 +55
+ Misses 44520 44517 -3
Partials 592 592 ☔ View full report in Codecov by Sentry. |
|
closes #18014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20882