-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP docs(python): Add expression composability to PySpark comparison #21473
Draft
MarcoGorelli
wants to merge
4
commits into
pola-rs:main
Choose a base branch
from
MarcoGorelli:composing-expressions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8543e4
to
1fa7cc5
Compare
1fa7cc5
to
aef0c14
Compare
ritchie46
reviewed
Feb 26, 2025
) | ||
``` | ||
|
||
In PySpark however this is not allowed, as `shift`/`lag` is not a scalar (i.e. elementwise) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe spark only allows reductions (looking at the code example you provided).
Suggested change
In PySpark however this is not allowed, as `shift`/`lag` is not a scalar (i.e. elementwise) | |
In PySpark however this is not allowed, as `shift`/`lag` is not a scalar (i.e. reduction) |
ritchie46
reviewed
Feb 26, 2025
|
||
### Example 3: Composing expressions | ||
|
||
Polars allow you compose expressions quite liberally. For example, if you want to find the rolling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
python
Related to Python Polars
title needs formatting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing Narwhals has really made me appreciate how good Polars and its API is 😄 🙌
EDIT: checking this, will update shortly