refactor(rust): Map Polars AssertionError to pyo3's AssertionError and improve macro flexibility
#21495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevin-Patyk
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Kevin-Patyk
changed the title
AssertionError to pyo3's AssertionError and improve macro flexibility AssertionError to pyo3's AssertionError and improve macro flexibility
github-actions
bot
added
internal
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21495 +/- ##
=======================================
Coverage 79.98% 79.98%
=======================================
Files 1598 1598
Lines 229320 229321 +1
Branches 2623 2623
=======================================
+ Hits 183412 183421 +9
+ Misses 45303 45295 -8
Partials 605 605 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Feb 28, 2025
anath2
pushed a commit
to anath2/polars
that referenced
this pull request
Mar 5, 2025
…` and improve macro flexibility (pola-rs#21495)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is regarding comments from @coastalwhite on this PR: #21460 and from Discord regarding using pyo3's built in
AssertionErrorand using the macro for more general assertions.Previous PR relates to issue: #21388.
polars-error/lib.rs, the macro has been updated to be more generalize and also match the already existing Python assertion error.error.rs,PolarsError::AssertionErrorhas been mapped toPyAssertionErrorrather than making a new exception.exceptions.rs, thecreate_exception_macro!()has been removed forAssertionErrorsince it will be relying on pyo3's existing implementation.