Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename 'join_nulls' parameter to 'nulls_equal' in join functions #21507

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

mcrumiller
Copy link
Contributor

As per Ritchie's request, this brings more consistency to the parameter.

I kept the join_nulls function the same name since in that case it's a verb and it makes sense, but as a parameter name it was a simple rename.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.81%. Comparing base (e801b83) to head (7ebd82d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...s/src/frame/join/hash_join/single_keys_dispatch.rs 89.04% 8 Missing ⚠️
crates/polars-stream/src/nodes/joins/equi_join.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21507      +/-   ##
==========================================
- Coverage   79.81%   79.81%   -0.01%     
==========================================
  Files        1592     1592              
  Lines      229266   229299      +33     
  Branches     2623     2623              
==========================================
+ Hits       182991   183014      +23     
- Misses      45670    45680      +10     
  Partials      605      605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit e537b3b into pola-rs:main Feb 28, 2025
31 checks passed
anath2 pushed a commit to anath2/polars that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants