Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Don't maintain order when maintain_order=False in new streaming sinks #21586

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 58.42697% with 37 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@fe56f69). Learn more about missing BASE report.
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s/polars-stream/src/async_primitives/linearizer.rs 33.33% 16 Missing ⚠️
crates/polars-plan/src/dsl/options.rs 0.00% 6 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/csv.rs 62.50% 3 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/ipc.rs 0.00% 3 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/json.rs 62.50% 3 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/parquet.rs 0.00% 3 Missing ⚠️
crates/polars-python/src/lazyframe/sink.rs 81.81% 2 Missing ⚠️
crates/polars-stream/src/pipe.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21586   +/-   ##
=======================================
  Coverage        ?   79.78%           
=======================================
  Files           ?     1604           
  Lines           ?   231422           
  Branches        ?     2639           
=======================================
  Hits            ?   184646           
  Misses          ?    46167           
  Partials        ?      609           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 51caaed into pola-rs:main Mar 4, 2025
29 checks passed
anath2 pushed a commit to anath2/polars that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants