Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Closeable files on unix #21588

Merged
merged 5 commits into from
Mar 5, 2025
Merged

feat: Closeable files on unix #21588

merged 5 commits into from
Mar 5, 2025

Conversation

ritchie46
Copy link
Member

@nameexhaustion nameexhaustion mentioned this pull request Mar 5, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.30435% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.91%. Comparing base (a1c6834) to head (5575ed3).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-utils/src/file.rs 89.47% 4 Missing ⚠️
crates/polars-python/src/conversion/mod.rs 0.00% 2 Missing ⚠️
crates/polars-python/src/file.rs 90.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #21588      +/-   ##
==========================================
+ Coverage   79.80%   79.91%   +0.11%     
==========================================
  Files        1604     1605       +1     
  Lines      231362   231582     +220     
  Branches     2639     2639              
==========================================
+ Hits       184629   185065     +436     
+ Misses      46124    45908     -216     
  Partials      609      609

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

The uncompressed lib size after this PR is 41.9499 MB.

@ritchie46 ritchie46 changed the title wip: Closeable files feat: Closeable files on unix Mar 5, 2025
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Mar 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

The uncompressed lib size after this PR is 41.9512 MB.

@ritchie46 ritchie46 merged commit 55be31f into main Mar 5, 2025
21 checks passed
@ritchie46 ritchie46 deleted the file branch March 5, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ritchie46