Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly handle phase transitions in row-wise sinks #21600

Merged

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@coastalwhite coastalwhite marked this pull request as draft March 5, 2025 09:27
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 5, 2025
@coastalwhite coastalwhite force-pushed the fix/row-wise-phase-transistions branch from f9948ff to 3cefb99 Compare March 5, 2025 09:37
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 87.87879% with 24 lines in your changes missing coverage. Please review.

Project coverage is 80.59%. Comparing base (aa8e47f) to head (b06cc31).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/io_sinks/mod.rs 81.03% 11 Missing ⚠️
...rs-stream/src/nodes/io_sinks/partition/max_size.rs 87.05% 11 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/csv.rs 96.96% 1 Missing ⚠️
crates/polars-stream/src/nodes/io_sinks/json.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21600      +/-   ##
==========================================
+ Coverage   80.57%   80.59%   +0.02%     
==========================================
  Files        1604     1604              
  Lines      231633   231526     -107     
  Branches     2650     2650              
==========================================
- Hits       186637   186606      -31     
+ Misses      44379    44303      -76     
  Partials      617      617              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coastalwhite coastalwhite marked this pull request as ready for review March 6, 2025 16:21
@coastalwhite coastalwhite force-pushed the fix/row-wise-phase-transistions branch from 6663f17 to b06cc31 Compare March 6, 2025 16:23
@coastalwhite coastalwhite merged commit 33ed4b7 into pola-rs:main Mar 7, 2025
27 checks passed
@coastalwhite coastalwhite deleted the fix/row-wise-phase-transistions branch March 7, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant