Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove even more parquet multiscan handling #21601

Merged

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Mar 5, 2025
@coastalwhite coastalwhite marked this pull request as ready for review March 5, 2025 13:50
@coastalwhite
Copy link
Collaborator Author

@orlp this should also partially fix the slowdown on q7 I believe

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 84.22819% with 47 lines in your changes missing coverage. Please review.

Project coverage is 80.03%. Comparing base (db551fb) to head (1d37494).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...polars-stream/src/nodes/io_sources/parquet/init.rs 80.50% 31 Missing ⚠️
...c/nodes/io_sources/parquet/row_group_data_fetch.rs 83.75% 13 Missing ⚠️
crates/polars-io/src/parquet/read/predicates.rs 93.75% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21601      +/-   ##
==========================================
+ Coverage   79.75%   80.03%   +0.28%     
==========================================
  Files        1604     1604              
  Lines      231527   231328     -199     
  Branches     2639     2639              
==========================================
+ Hits       184658   185147     +489     
+ Misses      46260    45572     -688     
  Partials      609      609              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 3cc36bf into pola-rs:main Mar 5, 2025
20 of 21 checks passed
@coastalwhite coastalwhite deleted the refactor/remove-parquet-multiscan branch March 5, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants