Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cloud support for new-streaming scans and sinks #21621

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Mar 6, 2025

Enables cloud support for all scan and sink functions on new-streaming, including PartitionMaxSize.

Note that currently if any errors occur in writing they are silently ignored (there is a fix for this at https://github.com/pola-rs/polars/pull/21589/files#diff-744a743b5337b77c8e26e0efabdfe8410bfd77e3d1e55ffa54eb0f29cc51e33bR1177)

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 99.07407% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.25%. Comparing base (6f59975) to head (34f5d17).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/dsl/scan_sources.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21621      +/-   ##
==========================================
+ Coverage   80.23%   80.25%   +0.02%     
==========================================
  Files        1604     1604              
  Lines      231433   231491      +58     
  Branches     2639     2640       +1     
==========================================
+ Hits       185679   185784     +105     
+ Misses      45145    45098      -47     
  Partials      609      609              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nameexhaustion nameexhaustion marked this pull request as ready for review March 6, 2025 10:16
@ritchie46 ritchie46 merged commit eda0213 into pola-rs:main Mar 6, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants