refactor(rust): Remove once_cell in favor of std equivalents
#21639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
nameexhaustion
changed the title
once_cell to stdonce_cell
nameexhaustion
commented
Mar 7, 2025
| @@ -101,7 +100,8 @@ impl From<u8> for StateFlags { | |||
| } | |||
| } | |||
|
|
|||
| type CachedValue = Arc<(AtomicI64, OnceCell<DataFrame>)>; | |||
| // TODO: Replace with `OnceLock<DataFrame>` after `OnceLock::get_or_try_init` is stabilized. | |||
| type CachedValue = Arc<(AtomicI64, OnceLock<PolarsResult<DataFrame>>)>; | |||
There was a problem hiding this comment.
get_or_try_init is not stabilized, but this is the only use of it in the codebase. We instead directly store the result type in the oncelock.
There was a problem hiding this comment.
I am rewriting the cache. That will remove this usage.
There was a problem hiding this comment.
After this one, it should be good to go:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21639 +/- ##
=======================================
Coverage 80.54% 80.54%
=======================================
Files 1603 1603
Lines 231258 231258
Branches 2650 2650
=======================================
+ Hits 186265 186266 +1
+ Misses 44376 44375 -1
Partials 617 617 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
nameexhaustion
force-pushed
the
std-cell
branch
3 times, most recently
from
b218d7e to
4c676fe
Compare
nameexhaustion
changed the title
once_cellonce_cell in favor of std equivalents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
once_cellas a direct dependency, as the functions have been added and stabilized in std. Note that the names will differ:*edit, drafted on second thought