Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize only a single cache input #21644

Merged
merged 2 commits into from
Mar 7, 2025
Merged

perf: Optimize only a single cache input #21644

merged 2 commits into from
Mar 7, 2025

Conversation

ritchie46
Copy link
Member

This removes quadratic behavior in CSE.

#21637

@ritchie46 ritchie46 requested review from orlp and c-peters as code owners March 7, 2025 10:32
@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

The uncompressed lib size after this PR is 42.0596 MB.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 98.27586% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.54%. Comparing base (ae519ea) to head (3a779df).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/polars-plan/src/plans/optimizer/cache_states.rs 98.21% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21644      +/-   ##
==========================================
- Coverage   80.56%   80.54%   -0.03%     
==========================================
  Files        1603     1603              
  Lines      231654   231266     -388     
  Branches     2650     2650              
==========================================
- Hits       186631   186263     -368     
+ Misses      44406    44386      -20     
  Partials      617      617              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ritchie46 ritchie46 merged commit 36c49ed into main Mar 7, 2025
23 checks passed
@ritchie46 ritchie46 deleted the cache branch March 7, 2025 10:55
@mcrumiller
Copy link
Contributor

Hi @ritchie46, this didn't actually close the referenced issue.

@ritchie46
Copy link
Member Author

Hi @ritchie46, this didn't actually close the referenced issue.

Intentional. This one does: #21646 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants