INT-1061 #25
Open
INT-1061 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarus
requested changes
Nov 26, 2024
| @@ -89,8 +89,7 @@ function doLookup(entities, options, cb) { | |||
|
|
|||
| limiter.submit(requestEntity, entity, requestOptions, (err, result) => { | |||
| const maxRequestQueueLimitHit = | |||
| (isEmpty(err) && isEmpty(result)) || | |||
| (err && err.message === 'This job has been dropped by Bottleneck'); | |||
| ((err === null || typeof err === 'undefined') && _.isEmpty(results)) || (err && err.message === 'This job has been dropped by Bottleneck'); | |||
There was a problem hiding this comment.
@aion-tc A few issues here due to slight differences between integrations
_ (lodash) is not defined. Instead isEmpty is imported via lodash/fp and can be directly accessed.
results is undefined here and should be result.
Final line should be:
const maxRequestQueueLimitHit =
((err === null || typeof err === 'undefined') && isEmpty(result)) ||
(err && err.message === 'This job has been dropped by Bottleneck');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing retry logic that "swallows" runtime errors in integrations that use Bottleneck. I added Adriana as reviewer for learning purposes.