338 task move ira table columns #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengyin-shan
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Hi @ylyangtw , I tested the Docker, and it ran smoothly. Great job on enabling this functionality!
However, I noticed a bug in the calculation of the IRA tables after your modification:
- In the dollar table, the "All Practices" columns are not correctly summing up the sub-columns' totals.
- Similarly, in the percentage table, the "All Practices" columns do not reflect the overall nationwide percentage (note that this percentage is not calculated by summing up individual percentages).
Here is the test case I used:
- "AGRICULTURAL ENERGY ASSESSMENT (228)"
- "ENERGY EFFICIENT BUILDING ENVELOPE (672)"
- "FORAGE HARVEST MANAGEMENT (511)"
Results
In your branch:
Versus in production:
Let me know if you have any questions or need further clarification!
pengyin-shan
approved these changes
Dec 13, 2024
navarroc
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under IRA tables, you should see ALL PRACTICES columns have been moved to the leftmost. Downloaded csv shows the same too.
