Remove require_weight_at_most from XCM Transact
#101
Conversation
acatangiu
force-pushed
the
xcm-transact-allow-unlimited-weight
branch
from
61e7e8e to
46de281
Compare
Replace the `require_weight_at_most: Weight` parameter of the Transact instruction with a weight limit: `weight_limit: WeightLimit` that allows `Unlimited` variant. Motivation The UX of using Transact is not great, and one part of the problem is guesstimating this require_weight_at_most. We've seen multiple Transacts on-chain failures caused by the "incorrect" use or the parameter. In practice, this parameter only adds UX overhead. Use cases fall in one of two categories: 1. Unpaid execution of Transacts - in these cases the require_weight_at_most is not really useful, caller doesn't have to pay for it, and on the call site it either fits the block or not; 2. Paid execution of single Transact - the weight to be spent by the Transact is already covered by the BuyExecution weight limit parameter. We've had multiple OpenGov root/whitelisted_caller proposals initiated by core-devs, completely or partially fail because of incorrect configuration of `require_weight_at_most` parameter. This is a strong indication that the instruction in its current form is hard to use. Signed-off-by: Adrian Catangiu <adrian@parity.io>
acatangiu
force-pushed
the
xcm-transact-allow-unlimited-weight
branch
from
46de281 to
d18bf46
Compare
acatangiu
changed the title
require_weight_at_most from XCM Transact
|
/rfc propose |
|
Hey @franciscoaguirre, here is a link you can use to create the referendum aiming to approve this RFC number 0101. Instructions
It is based on commit hash eb318aed0c8e0282f17197b9ddad8102c79c90b4. The proposed remark text is: |
|
Voting for this referenda is ongoing. Vote for it here |
|
PR can be merged. Write the following command to trigger the bot
|
|
/rfc process 0xff7432136fbaa2c74352e316264820c79078f2b0550d41de6e7e901e4f748833 |
|
The on-chain referendum has approved the RFC. |
|
Just belatedly confirming that removing |
This is a continuation of polkadot-fellows/xcm-format#55 following the migration of XCM RFCs to this repo.
Summary
Remove the
require_weight_at_most: Weightparameter of the Transact instruction.Motivation
The UX of using Transact is not great, and one part of the problem is guesstimating this require_weight_at_most.
We've seen multiple Transacts on-chain failures caused by the "incorrect" use or the parameter. In practice, this parameter only adds UX overhead. Use cases fall in one of two categories:
We've had multiple OpenGov root/whitelisted_caller proposals initiated by core-devs, completely or partially fail because of incorrect configuration of
require_weight_at_mostparameter. This is a strong indication that the instruction in its current form is hard to use.