Remove unneeded std::shared_from_this from Sink

Signed-off-by: Pavel Artsishevsky <polter.rnd@gmail.com>
polter-rnd · Nov 27, 2024 · f3f2dd3 · f3f2dd3
1 parent 0cbaffb
commit f3f2dd3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/include/slimlog/sink-inl.h b/include/slimlog/sink-inl.h
@@ -33,18 +33,16 @@
 namespace SlimLog {
 
 template<typename Logger>
-auto Sink<Logger>::set_pattern(StringViewType pattern) -> std::shared_ptr<Sink<Logger>>
+auto Sink<Logger>::set_pattern(StringViewType pattern) -> void
 {
     m_pattern.set_pattern(std::move(pattern));
-    return this->shared_from_this();
 }
 
 template<typename Logger>
 auto Sink<Logger>::set_levels(std::initializer_list<std::pair<Level, StringViewType>> levels)
-    -> std::shared_ptr<Sink<Logger>>
+    -> void
 {
     m_pattern.set_levels(std::move(levels));
-    return this->shared_from_this();
 }
 
 template<typename Logger>

diff --git a/include/slimlog/sink.h b/include/slimlog/sink.h
@@ -30,7 +30,7 @@ namespace SlimLog {
  * @tparam Logger The logger class type intended for use with this sink.
  */
 template<typename Logger>
-class Sink : public std::enable_shared_from_this<Sink<Logger>> {
+class Sink {
 public:
     /** @brief String type for log messages. */
     using StringType = typename Logger::StringType;
@@ -97,7 +97,7 @@ class Sink : public std::enable_shared_from_this<Sink<Logger>> {
      * @param pattern Log message pattern.
      * @return Pointer to the self sink object.
      */
-    virtual auto set_pattern(StringViewType pattern) -> std::shared_ptr<Sink<Logger>>;
+    virtual auto set_pattern(StringViewType pattern) -> void;
 
     /**
      * @brief Sets the log level names.
@@ -111,8 +111,7 @@ class Sink : public std::enable_shared_from_this<Sink<Logger>> {
      * @param levels List of log levels with corresponding names.
      * @return Pointer to the self sink object.
      */
-    virtual auto set_levels(std::initializer_list<std::pair<Level, StringViewType>> levels)
-        -> std::shared_ptr<Sink<Logger>>;
+    virtual auto set_levels(std::initializer_list<std::pair<Level, StringViewType>> levels) -> void;
 
     /**
      * @brief Processes a log record.