Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Funcky.Xunit Packages for xUnit v3 #821

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Add Funcky.Xunit Packages for xUnit v3 #821

merged 1 commit into from
Jan 30, 2025

Conversation

bash
Copy link
Member

@bash bash commented Jan 28, 2025

xUnit v3 is finally here 🎉

We could either:

  • Update Funcky.Xunit to xUnit v3. This means that we force ourselves and our consumers to update to xUnit v3 right now (a lot of third-party libraries such as FsCheck.Xunit are not yet updated to v3)
  • Take the same approach that xUnit itself uses i.e. appending .v3 to the packages. This is what this PR does.

Do we still want to include ToTheoryData in v3? The new theory data is much more powerful:

  • Collection expressions work for TheoryData:
    public static TheoryData<int, string> IntegersAndStringRepr => [
        (10, "10"),
        (20, "20"),
    ];
  • Enumerables can easily be converted to TheoryData by passing it to its constructor:
    public static TheoryData<int, string> IntegersAndStringRepr => new(
        Enumerable.Range(0, count: 5)
            .Select(n => n * 10)
            .Select(n => (n, n.ToString())));

@bash bash enabled auto-merge January 28, 2025 11:34
@FreeApophis
Copy link
Member

I think you can remove it from v3. Otherwise I think that’s the only nice way, even though it is very stupid..

@bash bash merged commit d425909 into main Jan 30, 2025
9 checks passed
@bash bash deleted the xunit-v3 branch January 30, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants