Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SemanticVersioning targets #826

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

bash
Copy link
Member

@bash bash commented Jan 29, 2025

Resolves #823

@bash bash requested a review from FreeApophis January 29, 2025 17:15
@bash bash enabled auto-merge January 29, 2025 17:15
FreeApophis
FreeApophis previously approved these changes Jan 30, 2025
@FreeApophis
Copy link
Member

FreeApophis commented Jan 30, 2025

NuGet generation fails with: error MSB4018: The "GenerateSemanticVersionRanges" task failed unexpectedly.

@bash
Copy link
Member Author

bash commented Jan 30, 2025

I decided to extract this into its own package. This makes the whole dependency thing a lot easier (I can pack NuGet.SemanticVersioning together with the task) and allows us to use it in other repos too :)

See: polyadic/build#1

@FreeApophis
Copy link
Member

Still do not understand what it actually should do.

@bash
Copy link
Member Author

bash commented Jan 30, 2025

Still do not understand what it actually should do.

The goal or the implementation?

@bash bash force-pushed the fix-semantic-versioning-targets branch from c045740 to 9ac2bcb Compare January 30, 2025 16:14
@bash bash force-pushed the fix-semantic-versioning-targets branch from 9ac2bcb to 0fceea4 Compare January 30, 2025 16:15
@FreeApophis
Copy link
Member

I think I do not understand the goal, and therefore the implementation does not help.

@bash
Copy link
Member Author

bash commented Feb 3, 2025

Ah 😅

The goal is to reference Funcky using a semantic version range e.g. [3.5.0, 4) from the other NuGet packages in this repo instead of the default >=3.5.0.

The implementation does this by hooking into the pack process (that's what the Polyadic.Build.SemanticVersioning.targets file does).
It replaces the versions of each ProjectReference with an auto-generated range (that's what the GenerateSemanticVersionRanges is for).

@bash bash merged commit 5ca841b into main Feb 3, 2025
9 checks passed
@bash bash deleted the fix-semantic-versioning-targets branch February 3, 2025 09:46
@FreeApophis
Copy link
Member

I see - the problem was not xUnit but the fact that it is project reference. No wonder I was confused. Approved and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SemanticVersioning.targets breaks build on VisualStudio
2 participants